Revert "src: remove trace_sync_io_ from env"#28926
Closed
ChALkeR wants to merge 1 commit intonodejs:masterfrom
Closed
Revert "src: remove trace_sync_io_ from env"#28926ChALkeR wants to merge 1 commit intonodejs:masterfrom
ChALkeR wants to merge 1 commit intonodejs:masterfrom
Conversation
Contributor
|
Is it possible to add a regression test? |
addaleax
approved these changes
Aug 1, 2019
Member
addaleax
left a comment
There was a problem hiding this comment.
Thank you for catching this!
Member
Author
|
@cjihrig I will try to do that later this week, but I don't think that it is required in order to do a revert. |
Trott
approved these changes
Aug 1, 2019
cjihrig
approved these changes
Aug 1, 2019
jasnell
approved these changes
Aug 1, 2019
Collaborator
Collaborator
This reverts commit 7fa5f54. The reverted commit breaks the logic behind --trace-sync-io, it should be enabled only at a certain point in time, while that commit enables it from the very start, causing warnings be printed for all sync io instead of sync io after the first tick of the event loop as documented. Fixes: nodejs#28913 Refs: nodejs#22726 Refs: https://nodejs.org/api/cli.html#cli_trace_sync_io PR-URL: nodejs#28926
31cbdd7 to
31973cc
Compare
Member
Author
|
Force-push just now does not change the code, just altered the commit message to add an explanation and refs. |
4 tasks
Collaborator
Member
|
Landed in aa252eb |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 4, 2019
This reverts commit 7fa5f54. The reverted commit breaks the logic behind --trace-sync-io, it should be enabled only at a certain point in time, while that commit enables it from the very start, causing warnings be printed for all sync io instead of sync io after the first tick of the event loop as documented. Fixes: nodejs#28913 Refs: nodejs#22726 Refs: https://nodejs.org/api/cli.html#cli_trace_sync_io PR-URL: nodejs#28926 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Aug 6, 2019
This reverts commit 7fa5f54. The reverted commit breaks the logic behind --trace-sync-io, it should be enabled only at a certain point in time, while that commit enables it from the very start, causing warnings be printed for all sync io instead of sync io after the first tick of the event loop as documented. Fixes: #28913 Refs: #22726 Refs: https://nodejs.org/api/cli.html#cli_trace_sync_io PR-URL: #28926 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 7fa5f54.
Fixes: #28913
7fa5f54 breaks the logic behind
--trace-sync-io, it should be enabled only at a certain point in time, while that commit enables it from the very start, causing the issue linked above.Or am I missing something?
Refs: https://nodejs.org/api/cli.html#cli_trace_sync_io
Refs: #22726
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes